[coreboot] Patches [FLASHROM] SB600 SPI driver and sst25vf080b

Uwe Hermann uwe at hermann-uwe.de
Fri Nov 28 23:00:44 CET 2008

On Fri, Nov 28, 2008 at 04:16:13PM +0100, Uwe Hermann wrote:
> On Fri, Nov 28, 2008 at 01:06:54PM +0800, Wang, Qingpei wrote:
> > Signed-off-by:  Jason Wang <Qingpei.Wang at amd.com>
> > Reviewed-by:   Joe Bao <zheng.bao at amd.com>
> Thanks for the sb600 patch! I'll try to test it on my sb600 board this
> evening; I'll report back on how it works.

I have committed the patch in r3779, the code worked fine on my
RS690/SB600 board after a few changes.

The most important changes is to drop the "sleep(1)" from
sb600_spi_write() as otherwise writing takes _veery_ long (I actually
killed flashrom after 7-8 minutes as I didn't want to wait longer).
Without the sleep() a full write of a 1MB chip still takes 2:30 minutes,
I'm not sure if that's normal.

Another change I did, was to change 'outb' to 'OUTB' to make it portable
to other systems (*BSD).

The rest of the changes is purely coding-style fixes and making the
printf() output a bit more consistent with the rest of flashrom.

One other change I'd suggest is this:

Index: sb600spi.c
--- sb600spi.c  (revision 3779)
+++ sb600spi.c  (working copy)
@@ -1,9 +1,7 @@
  * This file is part of the flashrom project.
- * Copyright (C) 2008 Stefan Wildemann <stefan.wildemann at kontron.com>
- * Copyright (C) 2008 Claus Gindhart <claus.gindhart at kontron.com>
- * Copyright (C) 2008 Dominik Geyer <dominik.geyer at kontron.com>
+ * Copyright (C) 2008 Advanced Micro Devices, Inc.
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by

The sb600spi.c file may have started out by copying the ichspi.c file
(that's where the copyright lines come from), but AFAICS pretty much none
of that content is left in sb600spi.c, so the copyright lines should
be adapted accordingly. Please let me know if that's ok.

Thanks again for the great patch!

http://www.hermann-uwe.de  | http://www.holsham-traders.de
http://www.crazy-hacks.org | http://www.unmaintained-free-software.org

More information about the coreboot mailing list