[coreboot] v3 stage0

ron minnich rminnich at gmail.com
Mon Oct 6 22:47:11 CEST 2008

What's happening to my typing today? Try again. I think the dbm690t
work fried my brain.

On Mon, Oct 6, 2008 at 1:46 PM, ron minnich <rminnich at gmail.com> wrote:
> On Mon, Oct 6, 2008 at 1:15 PM, Carl-Daniel Hailfinger
> <c-d.hailfinger.devel.2006 at gmx.net> wrote:
>> Hi,
>> currently we have 3 different files with stage0 asm code sharing lots of
>> delicate code:
>> - amd/stage0.S
>> - geodelx/stage0.S
>> - stage0_i586.S
>> and all of them share at least the complete 16bit code which is near
>> unreadable in itself.
>> Can we extract the 16bit code into a common file and include it? I know
>> that choice isn't going to be too popular because it makes the code more
>> greppy. However, keeping all instances of that code in sync is a major
>> headache and we even have remaining bugs in the common copied 32bit
>> parts of that code.
>> If that's not possible, I'd like to at least enforce a rule which keeps
>> the common 16-bit code bit-for-bit identical including comments.
> one file is fine. The v32 code is a total nightmare, so I would really
> like to avoid turning it into that mess.

One include file is fine. I want to avoid the v2 experience but there
is a middle ground and I think you could find it.



More information about the coreboot mailing list