[coreboot] [PATCH] v3: vt8237 stage1 support

[Corey Osgood]

On Tue, Oct 14, 2008 at 6:46 AM, Carl-Daniel Hailfinger <
c-d.hailfinger.devel.2006 at gmx.net> wrote:

> On 14.10.2008 05:33, Corey Osgood wrote:
> > See attached. Stage2 has to wait until CAR can be disabled on C7.
> >
> > Add stage1 support for vt8237[RS] to v3.
> >
> > Signed-off-by: Corey Osgood <corey.osgood at gmail.com>
> >
>
> Looks good. I didn't understand one part of the code and would
> appreciate clarifications, though.
> Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net>


With the fixes you mentioned, committed in r928


> > +void enable_smbus(u16 smbus_io_base)
> > +{
> > +     u32 dev;
> > +
> > +     /* Power management controller */
> > +     pci_conf1_find_device(PCI_VENDOR_ID_VIA,
> PCI_DEVICE_ID_VIA_VT8237R_LPC,
> > +                             &dev);
> >
>
> OK, here you look for PCI_DEVICE_ID_VIA_VT8237R_LPC
>
> > +
> > +     if (pci_conf1_read_config16(dev, PCI_DEVICE_ID) !=
> > +                             PCI_DEVICE_ID_VIA_VT8237R_LPC) {
> >
>
> And here you check what? If pci_conf1_find_device is not broken and
> returns a nonzero value, the expression above should be always false. I
> believe this is a romcc relic.


A relic of my own laziness, actually. I meant to look up
pci_conf1_fird_device() to see what it returned, threw that in as a stopgap,
and forgot about it.

Thanks,
Corey
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20081014/dd976d52/attachment.html>