[coreboot] r3660 - trunk/coreboot-v2/src/southbridge/via/vt8237r

svn at coreboot.org svn at coreboot.org
Thu Oct 16 17:05:18 CEST 2008

Author: hailfinger
Date: 2008-10-16 17:05:18 +0200 (Thu, 16 Oct 2008)
New Revision: 3660

Revision 3567 introduced __attribute__((packed)) for a structured which
is also visible to ROMCC and ROMCC doesn't understand that.

The fix is to use __attribute__((packed)) only for gcc compiled code.

This has been unfixed for too long. There are more problems remaining,
but at least this one is solvable easily.

Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net>
Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net>

Modified: trunk/coreboot-v2/src/southbridge/via/vt8237r/vt8237r.h
--- trunk/coreboot-v2/src/southbridge/via/vt8237r/vt8237r.h	2008-10-15 17:50:29 UTC (rev 3659)
+++ trunk/coreboot-v2/src/southbridge/via/vt8237r/vt8237r.h	2008-10-16 15:05:18 UTC (rev 3660)
@@ -93,6 +93,10 @@
 	u8 cfg_c;
 	u8 cfg_d;
 	u8 checksum;
-} __attribute__ ((packed));
+#if defined(__GNUC__)
+__attribute__ ((packed))

More information about the coreboot mailing list