[coreboot] [PATCH] v2: BCOM WinNETP680 improvements
corey.osgood at gmail.com
Fri Oct 17 23:39:28 CEST 2008
On Fri, Oct 17, 2008 at 5:12 PM, Alex Mauer <hawke at hawkesnest.net> wrote:
> Corey Osgood wrote:
>> 2008/10/17 Uwe Hermann <uwe at hermann-uwe.de <mailto:uwe at hermann-uwe.de>>
>> See patch.
>> Drop unneeded enable_mainboard_devices() function, the lines
>> register "fn_ctrl_lo" = "0x80"
>> register "fn_ctrl_hi" = "0x1d"
>> in the Config.lb file should do exactly the same (but please test
>> Also, drop some unused variables and (IMHO) unneeded debug messages.
>> NACK. If the devices aren't enabled/disabled (and in the process
>> hidden/revealed) before PCI bringup, coreboot will get very confused when
>> they disappear and appear out of nowhere.
> would it be feasible to have enable_mainboard_devices() read the structure
> setup by Config.lb so that those values can come from just one place?
No, unfortunately Config.lb is only available in post-raminit code. This is
one of the things that I hope to solve in V3. fn_ctrl_lo in v3 can be
replaced with actual function names in the dts (usb_ehci, , and with
Carl-Daniel's dts->flatfile work (whenever it's ready ;)), it can be
accessed from stage1/initram. This is just one of the reasons I've been
concentrating on getting the cn700 running on v3 more then worrying about
CAR on v2.
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the coreboot