[coreboot] [PATCH] superiotool: ITE IT8661 enter_conf_mode working

[Uwe Hermann]

Hi,

On Sat, Oct 18, 2008 at 03:19:03PM +0300, Urja Rannikko wrote:
> This patch adds a special test+enable conf mode function  for the
> IT8661 (and IT8770F which seems to be identical (same ID),
> thus the added "/IT8770F") which is called in the beginning of

Do you have an IT8770F datasheet? I haven't been able to find one.
I assume you know that it has the same ID as IT8661F because you
have a board with an IT8770F? Which one is that?


> enter_conf_mode_ite (and if it succeeds, skip other enables).
> 0x3F0 is added to the ITE scanned ports because the 8661/8770 can be
> programmed to 0x3F0,0x370 or 0x3BD only
> (gets programmed by the test function).

This is an interesting question -- is the config port hardcoded for each
board (and you have to use the correct one), or do you actually _choose_
the config port using the sequence below?

For newer Super I/Os the 0x2e or 0x4e config port is usually hardcoded
by the board designer, i.e. you don't get to choose it as the software
writer, but maybe this is different for this Super I/O (not sure).


> Also included is an proprietary bios dump from the board (with this
> patch) (that has an IT8770F).

Thanks, but please also mention which vendor/board this is from.

 
> +	outb(0x55,isapnp_addr);
> +	outb(0x55,isapnp_addr); /* Reset key check logic */

Why 0x55 here? Couldn't find that piece of information in the
(IT8661F) datasheet, I think.


> Index: superiotool.h
> ===================================================================
> --- superiotool.h	(revision 3667)
> +++ superiotool.h	(working copy)
> @@ -118,7 +118,7 @@
>  } superio_ports_table[] = {
>  	{probe_idregs_ali,	{0x3f0, 0x370, EOT}},
>  	{probe_idregs_fintek,	{0x2e, 0x4e, EOT}},
> -	{probe_idregs_ite,	{0x2e, 0x4e, EOT}},
> +	{probe_idregs_ite,	{0x2e, 0x4e, 0x3f0, EOT}},

Shouldn't 0x370 and 0x3bd also be added here then?


I'll test the patch on another IT8661F board and rewrite it a bit to
make it match the general superiotool architecture a bit more.


Uwe.
-- 
http://www.hermann-uwe.de  | http://www.holsham-traders.de
http://www.crazy-hacks.org | http://www.unmaintained-free-software.org