[coreboot] [PATCH] v2: sb600: Fix I/O port variable size, simplify code

Marc Jones Marc.Jones at amd.com
Tue Oct 21 18:12:43 CEST 2008

Uwe Hermann wrote:
> See patch.
> Uwe.

> I/O ports are 16bit, so change 'unsigned long port_base' to 'u16 port_base'.
> Also, use more readable #defines instead of hardcoded config ports for
> PM/PM2 related functions, and simplify them a bit.
> Build-tested with the AMD dbm690t target.
> Signed-off-by: Uwe Hermann <uwe at hermann-uwe.de>

Good stuff. Thanks!
Acked-by: Marc Jones <marc.jones at amd.com>

Marc Jones
Senior Firmware Engineer
(970) 226-9684 Office
mailto:Marc.Jones at amd.com

More information about the coreboot mailing list