[coreboot] HT_CHAIN.*_UNITID_BASE

[Myles Watson]

On Fri, Oct 24, 2008 at 10:10 AM, Myles Watson <mylesgw at gmail.com> wrote:

> Is this defined because of broken hardware?  I'm surprised that we need
> this.


Sorry that wasn't probably specific enough.  Here are some of the defines.
They complicate the code quite a bit.

mainboard/amd/dbm690t/mainboard.h:#define HT_CHAIN_UNITID_BASE 0x0
mainboard/amd/dbm690t/mainboard.h:#define HT_CHAIN_END_UNITID_BASE 0x6
mainboard/amd/dbm690t/mainboard.h:#define SB_HT_CHAIN_ON_BUS0 1
mainboard/amd/dbm690t/mainboard.h:#define SB_HT_CHAIN_UNITID_OFFSET_ONLY 0
mainboard/amd/serengeti/mainboard.h:#define HT_CHAIN_UNITID_BASE 0xa
mainboard/amd/serengeti/mainboard.h:#define HT_CHAIN_END_UNITID_BASE 0x6
mainboard/amd/serengeti/mainboard.h:#define SB_HT_CHAIN_ON_BUS0 2
mainboard/amd/serengeti/mainboard.h:#define SB_HT_CHAIN_UNITID_OFFSET_ONLY 1
mainboard/gigabyte/m57sli/mainboard.h:#define HT_CHAIN_UNITID_BASE 0
mainboard/gigabyte/m57sli/mainboard.h:#define HT_CHAIN_END_UNITID_BASE 0x6
mainboard/gigabyte/m57sli/mainboard.h:#define SB_HT_CHAIN_ON_BUS0 2
mainboard/gigabyte/m57sli/mainboard.h:#define SB_HT_CHAIN_UNITID_OFFSET_ONLY
0
mainboard/gigabyte/m57sli/mainboard.h:#define MCP55_DEVN_BASE
HT_CHAIN_UNITID_BASE

What I'm asking is if there is some reason that these values can't be
discovered.  If there isn't, could we put them in the dts, since that's
where people should be looking for this information?

Thanks,
Myles
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20081024/7e5049a4/attachment.html>