[coreboot] v3 __func0 cleanup

Marc Jones Marc.Jones at amd.com
Tue Oct 28 21:15:58 CET 2008

Myles Watson wrote:
> This patch documents the unreadable function in northbridge/amd/k8/pci.c and
> cleans up the NULL pointer protection.
> Signed-off-by: Myles Watson <mylesgw at gmail.com <mailto:mylesgw at gmail.com>>

Untested but this looks correct to me. See if Ron has some comment.

Acked-by: Marc Jones <marc.jones at amd.com>

> It also begs the question why cpu_bus_scan and cpu_bus_init aren't 
> needed in v3.  They aren't called.  Is that an oversight, or should they 
> be removed.

I think it is because the HT init (cpu setup) is all done pre-memory and 
done by the time dts is used. This could change if the dts is present in 


Marc Jones
Senior Firmware Engineer
(970) 226-9684 Office
mailto:Marc.Jones at amd.com

More information about the coreboot mailing list