[coreboot] r960 - coreboot-v3/northbridge/amd/k8

svn at coreboot.org svn at coreboot.org
Wed Oct 29 03:22:38 CET 2008


Author: myles
Date: 2008-10-29 03:22:38 +0100 (Wed, 29 Oct 2008)
New Revision: 960

Modified:
   coreboot-v3/northbridge/amd/k8/common.c
   coreboot-v3/northbridge/amd/k8/domain.c
   coreboot-v3/northbridge/amd/k8/pci.c
Log:
This patch documents the unreadable function in northbridge/amd/k8/pci.c and
cleans up the NULL pointer protection.

Signed-off-by: Myles Watson <mylesgw at gmail.com>
Acked-by: Marc Jones <marc.jones at amd.com>


Modified: coreboot-v3/northbridge/amd/k8/common.c
===================================================================
--- coreboot-v3/northbridge/amd/k8/common.c	2008-10-29 02:19:42 UTC (rev 959)
+++ coreboot-v3/northbridge/amd/k8/common.c	2008-10-29 02:22:38 UTC (rev 960)
@@ -80,28 +80,27 @@
 void get_fx_devs(void)
 {
 	int i;
-	if (__f1_dev[0]) {
-		return;
-	}
 	for(i = 0; i < FX_DEVS; i++) {
 		__f0_dev[i] = dev_find_slot(0, PCI_DEVFN(0x18 + i, 0));
 		__f1_dev[i] = dev_find_slot(0, PCI_DEVFN(0x18 + i, 1));
 	}
-	if (!__f1_dev[0]) {
-		die("Cannot find 0:0x18.1\n");
+	if (__f1_dev[0] == NULL || __f0_dev[0] == NULL) {
+		die("Cannot find 0:0x18.[0|1]\n");
 	}
 }
 
 u32 f1_read_config32(unsigned int reg)
 {
-	get_fx_devs();
+	if ( __f1_dev[0] == NULL)
+		get_fx_devs();
 	return pci_read_config32(__f1_dev[0], reg);
 }
 
 void f1_write_config32(unsigned int reg, u32 value)
 {
 	int i;
-	get_fx_devs();
+	if ( __f1_dev[0] == NULL)
+		get_fx_devs();
 	for(i = 0; i < FX_DEVS; i++) {
 		struct device * dev;
 		dev = __f1_dev[i];

Modified: coreboot-v3/northbridge/amd/k8/domain.c
===================================================================
--- coreboot-v3/northbridge/amd/k8/domain.c	2008-10-29 02:19:42 UTC (rev 959)
+++ coreboot-v3/northbridge/amd/k8/domain.c	2008-10-29 02:22:38 UTC (rev 960)
@@ -52,7 +52,6 @@
 
 #define FX_DEVS 8
 extern struct device * __f0_dev[FX_DEVS];
-void get_fx_devs(void);
 u32 f1_read_config32(unsigned int reg);
 void f1_write_config32(unsigned int reg, u32 value);
 unsigned int amdk8_nodeid(struct device * dev);
@@ -103,7 +102,6 @@
 
 	/* Find the already assigned resource pairs */
 	printk(BIOS_DEBUG, "k8_pci_domain_read_resources\n");
-	get_fx_devs();
 	for(reg = 0x80; reg <= 0xd8; reg+= 0x08) {
 		u32 base, limit;
 		base  = f1_read_config32(reg);
@@ -114,7 +112,7 @@
 			struct device * dev;
 			nodeid = limit & 7;
 			link   = (limit >> 4) & 3;
-			dev = __f0_dev[nodeid];
+			dev = __f0_dev[nodeid]; /* Initialized by f1_read_config32. */
 			if (dev) {
 				/* Reserve the resource  */
 				struct resource *resource;
@@ -379,10 +377,9 @@
 	/* Tune the hypertransport transaction for best performance.
 	 * Including enabling relaxed ordering if it is safe.
 	 */
-	get_fx_devs();
 	for(i = 0; i < FX_DEVS; i++) {
 		struct device * f0_dev;
-		f0_dev = __f0_dev[i];
+		f0_dev = __f0_dev[i]; /* Initialized by f1_write_config32. */
 		if (f0_dev && f0_dev->enabled) {
 			u32 httc;
 			httc = pci_read_config32(f0_dev, HT_TRANSACTION_CONTROL);

Modified: coreboot-v3/northbridge/amd/k8/pci.c
===================================================================
--- coreboot-v3/northbridge/amd/k8/pci.c	2008-10-29 02:19:42 UTC (rev 959)
+++ coreboot-v3/northbridge/amd/k8/pci.c	2008-10-29 02:22:38 UTC (rev 960)
@@ -48,6 +48,7 @@
 
 #define FX_DEVS 8
 extern struct device * __f0_dev[FX_DEVS];
+extern void get_fx_devs(void);
 u32 f1_read_config32(unsigned int reg);
 void f1_write_config32(unsigned int reg, u32 value);
 unsigned int amdk8_nodeid(struct device * dev);
@@ -63,7 +64,7 @@
 		unsigned max_bus;
 		unsigned min_bus;
 		unsigned max_devfn;
-	printk(BIOS_SPEW, "amdk8_scan_chain\n");
+		printk(BIOS_SPEW, "amdk8_scan_chain link %x\n",link);
 		dev->link[link].cap = 0x80 + (link *0x20);
 		do {
 			link_type = pci_read_config32(dev, dev->link[link].cap + 0x18);
@@ -242,16 +243,25 @@
 	return max;
 }
 
-#warning document this unreadable function reg_useable
+/** 
+ * reg_useable
+ * @param reg register to check
+ * @param goal_dev device to own the resource
+ * @param goal_nodeid node number
+ * @param goal_link link number
+ * @return 0 if not useable, 1 if useable, or 2 if the pair is free
+ * __f0 is initialized once in amdk8_read_resources
+ */
 static int reg_useable(unsigned reg,
 	struct device * goal_dev, unsigned goal_nodeid, unsigned goal_link)
 {
 	struct resource *res;
-	unsigned nodeid, link;
+	unsigned nodeid, link=0;
 	int result;
-	res = 0;
-#warning fix hard-coded 8 in for loop.
-	for(nodeid = 0; !res && (nodeid < 8); nodeid++) {
+	res = NULL;
+
+	/* Look for the resource that matches this register. */
+	for(nodeid = 0; !res && (nodeid < CONFIG_MAX_PHYSICAL_CPUS); nodeid++) {
 		struct device * dev;
 		dev = __f0_dev[nodeid];
 		if (! dev)
@@ -260,9 +270,12 @@
 			res = probe_resource(dev, 0x100 + (reg | link));
 		}
 	}
+	
+	/* If no allocated resource was found, it is free - return 2 */
 	result = 2;
 	if (res) {
 		result = 0;
+		/* If the resource is allocated to the link and node already */
 		if (	(goal_link == (link - 1)) &&
 			(goal_nodeid == (nodeid - 1)) &&
 			(res->flags <= 1)) {
@@ -277,7 +290,7 @@
 {
 	struct resource *resource;
 	unsigned free_reg, reg;
-	resource = 0;
+	resource = NULL;
 	free_reg = 0;
 	for(reg = 0xc0; reg <= 0xd8; reg += 0x8) {
 		int result;
@@ -304,7 +317,7 @@
 {
 	struct resource *resource;
 	unsigned free_reg, reg;
-	resource = 0;
+	resource = NULL;
 	free_reg = 0;
 	for(reg = 0x80; reg <= 0xb8; reg += 0x8) {
 		int result;
@@ -378,6 +391,9 @@
 	printk(BIOS_DEBUG, "amdk8_read_resources\n");
 	unsigned nodeid, link;
 	nodeid = amdk8_nodeid(dev);
+
+	get_fx_devs(); /* Make sure __f0 is initialized*/
+
 	for(link = 0; link < dev->links; link++) {
 		if (dev->link[link].children) {
 			printk(BIOS_DEBUG, "amdk8_read_resources link %d\n", link);
@@ -583,7 +599,7 @@
 		{.pci = {.vendor = PCI_VENDOR_ID_AMD,
 			      .device = 0x1100}}},
 	.constructor		 = default_device_constructor,
-	.reset_bus		= pci_bus_reset,
+	.reset_bus		 = pci_bus_reset,
 	.phase3_scan		 = amdk8_scan_chains,
 	.phase4_read_resources	 = amdk8_read_resources,
 	.phase4_set_resources	 = amdk8_set_resources,





More information about the coreboot mailing list