[coreboot] [PATCH] v3: Drop non-working vt1211 code, fix LDNs

Uwe Hermann uwe at hermann-uwe.de
Fri Oct 31 20:36:30 CET 2008

On Fri, Oct 31, 2008 at 07:49:52PM +0100, Peter Stuge wrote:
> > > +#define VT1211_HWM             11   /* Hardware Monitor */
> > 
> > The LDNs here are wrong (probably a copy of some Winbond Super I/O),
> > please check v2's vt1211.h or the datasheet for the correct ones.
> Not sure how I produced this but I definately did look at v2 for the
> serial port. I may have left the other untouched.

Yeah, serial should work, but superio.c is bogus.

> > > +++ superio/via/vt1211/superio.c	(revision 0)
> > 
> > Pretty much all of this file's code won't work/apply for VT1121,
> I know, I wrote that in the message. Are you suggesting that we need
> private repositories for work in progress?

No, I'm suggesting to not commit obviously non-working/broken code.
Instead, I suggest something like the attached patch for
work-in-progress commits, a small stub to make it compile, nothing more.

I fixed the LDNs in the *.h file and dropped all the broken stuff from
superio.c. Alternatively we might just as well drop superio.c completely
until a working version of it gets done (if the code can compile without
a superio.c being there).

http://www.hermann-uwe.de  | http://www.holsham-traders.de
http://www.crazy-hacks.org | http://www.unmaintained-free-software.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: v3_fix_vt1211_ldns_drop_broken_code.patch
Type: text/x-diff
Size: 7662 bytes
Desc: not available
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20081031/27ab4f6c/attachment.bin>

More information about the coreboot mailing list