[coreboot] K8 RAMinit problematic code
c-d.hailfinger.devel.2006 at gmx.net
Tue Sep 2 01:51:56 CEST 2008
On 01.09.2008 20:19, ron minnich wrote:
> On Mon, Sep 1, 2008 at 10:10 AM, Carl-Daniel Hailfinger
> <c-d.hailfinger.devel.2006 at gmx.net> wrote:
>> Sorry, I meant that
>> struct sys_info *sysinfox = ((CONFIG_LB_MEM_TOPK<<10) - DCACHE_RAM_GLOBAL_VAR_SIZE);
>> is broken beyond repair. Basically, that code tries to establish a new
>> location for global variables without telling anyone.
> yow! that's supposed to have been gone already! I wonder if a patch got lost.
Can you repost your remaining diff? I'll try to review ASAP.
>>> We're going to write this code as always SMP safe, and I want to
>>> remove the CONFIG_*_SMP conditionals. They make no sense for a bios.
>> Interesting point of view. As long as we're allowed to make locking on
>> pure uniprocessor architectures a no-op, I'm totally for it.
> yeah, locks on up always succeed and there's no contention :-)
I had a redefinition of the lock functions in mind because some
architectures may not have any fast/easy locking instructions.
More information about the coreboot