[coreboot] [PATCH] v2: Original import for mainboard msi/ms6147
Mats Erik Andersson
mats.andersson at gisladisker.se
Mon Sep 15 20:32:23 CEST 2008
Corey Osgood skrev alldeles nyss:
> Can you please test your patch with abuild, to make sure all i440bx
> targets build?
the quick answer is that the suggested patch does not touch
any common source file at all:
$ grep '+++' import_ms6147.diff
+++ src/mainboard/msi/ms6147/Config.lb (revision 0)
+++ src/mainboard/msi/ms6147/raminit.c (revision 0)
+++ src/mainboard/msi/ms6147/irq_tables.c (revision 0)
+++ src/mainboard/msi/ms6147/sdram.c (revision 0)
+++ src/mainboard/msi/ms6147/Options.lb (revision 0)
+++ src/mainboard/msi/ms6147/debug.c (revision 0)
+++ src/mainboard/msi/ms6147/chip.h (revision 0)
+++ src/mainboard/msi/ms6147/auto.c (revision 0)
+++ src/mainboard/msi/ms6147/mainboard.c (revision 0)
+++ targets/msi/ms6147/Config.lb (revision 0)
I intentionally made "private" copies of raminit.c and debug.c
in the mainboard directory, just to avoid breaking other
boards. The reason being that in particular "raminit.c"
does implement changes that could be detremental. However,
yesterday I did successfully build all other i440bx-boards
with a slightly more general version of my raminit.c.
According to your wish I will use abuild to see wether
raminit.c deserves to be promoted!
Mats E A
> On Mon, Sep 15, 2008 at 2:10 PM, Mats Erik Andersson
> <mats.andersson at gisladisker.se> wrote:
> > Action: First import of code basis for mainboard msi/ms6147.
> > Most files are taken unchange for chipset i440bx/i371eb,
> > but decisive changes have gone into raminit.c and debug.c,
> > which are thus positioned in the mainboard directory.
> > Mainboard is booting with dynamic memory detection.
> > Signed-by: Mats Erik Andersson <mats.andersson at gisladisker.org>
> > ---
> > My main contribution is to implement a functional detection
> > of populated RAM slots. The code has proven its ability to
> > detect, configure, and successfully initialize memory
> > ranging from 16MB+16MB in one slot, up to 64MB+64MB+64MB+64MB
> > in two slots. The mainboard has only two SDRAM slots, but the
> > code is able to work with one to four slots.
> > Best regards
> > Mats Erik Andersson
> > --
> > coreboot mailing list: coreboot at coreboot.org
> > http://www.coreboot.org/mailman/listinfo/coreboot
More information about the coreboot