[coreboot] libpayload/tinycurses keyboard driver fault

Jordan Crouse jordan.crouse at amd.com
Wed Sep 17 18:35:32 CEST 2008

On 17/09/08 18:31 +0200, Patrick Georgi wrote:
> Stefan Reinauer schrieb:
> > See patch
> >   
> Before someone commits this: the patch below fixes this by removing the
> code in question altogether, using the generic keyboard driver instead.
> That one was changed a bit, too, see patch header.
> Regards,
> Patrick Georgi

> - unify keycodes for non-ASCII keys by
>   using curses' codes and labels
> - fix ctrl-[a-z]
> - get rid of curses' ps/2 driver. uses generic one instead
> - #ifdef's around ps/2 keyboard handling and serial handling
> Signed-off-by: Patrick Georgi <patrick.georgi at coresystems.de>

Ohh - coresystems vs coresystems patch war! :)

I prefer the merged driver, but since I haven't tested either, I would
rather that the more stable of the two patches get committed if there is
an immediate bug to fix.


More information about the coreboot mailing list