[coreboot] dbm690t buildrom patch

[Ward Vandewege]

On Mon, Sep 22, 2008 at 02:10:06PM -0600, Marc Jones wrote:
> Add AMD dbm690t mainboard to buildrom.
> The dbm690t uses an embedded VBIOS which buildrom can attach to the ROM image.
> 
> Signed-off-by: Marc Jones <marc.jones at amd.com>
> Signed-off-by: Jordan Crouse <jordan.crouse at amd.com>a

If you address the few details below (and assuming the built image actually
boots - I don't have this board):

Acked-by: Ward Vandewege <ward at gnu.org>

> +config AMD_R690_HEADLESS
> +	bool "Build the R690 platform as headless (without VGA)"
> +	depends on ADVANCED && PLATFORM_DBM690T
> +	default n
> +	help
> +	  Say 'y' here to build without the VGA BIOS for the
> +	  R690 chipset.  This will result in no video graphics
> +	  for the platform.  This is not likely what you want,
> +	  so you should say 'n' here unless you are absolutely
> +	  sure.
> +
> +config AMD_R690_USE_VBIOS
> +	bool
> +	depends on !AMD_R690_HEADLESS
> +	default y
> +

So if I select this and not AMD_R690_CUSTOM_VBIOS, I get a bios image that
992768 bytes long and no warning that the video bios needs to be added. Is
that intended?

> +CBV3_TAG=HEAD
> +
> +COREBOOT_BOARD=dbm690t
> +CBV2_TDIR=dbm690t
> +CBV2_TAG=3092

This revision dies on first checkout with

  Fetching external item into
  '.../buildrom10/buildrom-devel/sources/coreboot/svn/util/lxbios'
  svn: URL 'svn://coreboot.org/repos/trunk/util/lxbios' doesn't exist
  Couldn't fetch the code from svn://coreboot.org/repos/trunk/coreboot-v2

Also, it doesn't have support for this board. I guess you really meant 3590
here.

> --- /dev/null	1970-01-01 00:00:00.000000000 +0000
> +++ buildrom-devel/packages/roms/amd_r690.mk	2008-09-22 10:21:09.000000000 -0600
> @@ -0,0 +1,11 @@
> +ifeq ($(CONFIG_AMD_R690_USE_VBIOS),y)
> +OPTIONROM_TARGETS += $(AMD_R690_VBIOS_LOCATION)
> +CBV2_PREPEND := $(AMD_R690_VBIOS_LOCATION)
> +endif
> +
> +$(AMD_R690_VBIOS_LOCATION):
> +	@ $(BIN_DIR)/show-instructions.sh \
> +	$(PACKAGE_DIR)/roms/amd_r690_instructions \
> +	$(AMD_R690_VBIOS_LOCATION)
> +	@ echo "Unable to find $(AMD_R690_VBIOS_LOCATION)"
> +	@ exit 1

There's an exec flag missing on the show-instructions.sh script; I get

make: execvp:
..../buildrom10/buildrom-devel/bin/show-instructions.sh:
Permission denied
make: *** [somewhere.rom] Error 127

Also, somehow it never showed me the contents of 

> Index: buildrom-devel/packages/roms/amd_r690_instructions
> ===================================================================
> --- /dev/null	1970-01-01 00:00:00.000000000 +0000
> +++ buildrom-devel/packages/roms/amd_r690_instructions	2008-09-21 15:51:11.000000000 -0600
> @@ -0,0 +1,10 @@
> +Please follow these instructions for downloading the video BIOS
> +for your R690 platform:
> +
> + * Download the latest video BIOS from:
> +   http://url.goes.here/

Does this url need to be filled in?

> + * Copy the file to:
> +   %DESTFILE%
> +   You may need to create the directory first.
> +
> +After copying the file, start the build again by typing 'make'.

This info never gets displayed for me. 

Thanks!
Ward.

-- 
Ward Vandewege <ward at fsf.org>
Free Software Foundation - Senior Systems Administrator