[coreboot] [PATCH 3/6] Intel EP80579 northbridge

Joseph Smith joe at settoplinux.org
Wed Sep 24 03:38:59 CEST 2008

On Tue, 23 Sep 2008 17:48:14 -0700, "Ed Swierk" <eswierk at arastra.com>
> On Tue, Sep 23, 2008 at 5:09 PM, Joseph Smith <joe at settoplinux.org>
>> Wait, making a common file for this?
>> struct dimm_size {
>>        unsigned long side1;
>>        unsigned long side2;
>> };
>> Four four lines of code that seems a little silly to me?
> This was in response to Uwe's suggestion--he would rather move the
> struct dimm_size to a common header file than duplicate it in numerous
> intel raminit files. I could go either way; this is pretty minor
> considering the overall level of redundancy in the northbridge code
> but I can see not wanting to make things worse.
>> Can you resend you patch, I don't think I got it.
> Here it is (unchanged from my 3 Sept message).
> Signed-off-by: Ed Swierk <eswierk at arastra.com>

Looks good if you have tested it on real hardware:

Acked-by: Joseph Smith <joe at settoplinux.org>

I don't think we should worry about intel_common.h for now, for four lines
of code. I can see simularities in the northbridge.c's but alot of the
raminit.c's have the same basic goal but do it very differently. I say we
get your code submitted now and worry about code consolidation later.

Joseph Smith

More information about the coreboot mailing list