[coreboot] [PATCH] v2: Use ARRAY_SIZE everywhere

Carl-Daniel Hailfinger c-d.hailfinger.devel.2006 at gmx.net
Wed Sep 24 17:32:37 CEST 2008

On 26.08.2008 00:09, Uwe Hermann wrote:
> On Fri, Aug 22, 2008 at 04:18:09PM +0200, Carl-Daniel Hailfinger wrote:
>> The ARRAY_SIZE macro is convenient, yet mostly unused. Switch lots of
>> code to use it. That makes the code more readable and also less error-prone.
>> I'd appreciate test builds. I see v3 as the future and occassional
>> patches to v2 are only intended to keep v2 roughly up to date with v3
>> code changes.
>> Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net>
> Looks good, but I only want to ack if this was build-tested with abuild
> and some sample payloads for all boards.

Survived a full abuild run.

> Did you check that stdlib.h is included everywhere where ARRAY_SIZE is
> used after the patch? Otherwise I expect compile errors.

Thanks for the hint, fixed in the tree. Do you want me to resend or is a
full abuild run sufficient?



More information about the coreboot mailing list