[coreboot] Config.lb WTF
rminnich at gmail.com
Sun Apr 12 00:02:58 CEST 2009
On Sat, Apr 11, 2009 at 2:24 PM, Peter Stuge <peter at stuge.se> wrote:
> Carl-Daniel Hailfinger wrote:
>> We have 22 different ways to invoke gcc inside Config.lb. That's
>> just embarrassing.
> I'd agree.
>> action "$(CC) $(DISTRO_CFLAGS) $(CFLAGS) $(CPPFLAGS) $(DEBUG_CFLAGS)
>> -I$(TOP)/src -I. -nostdinc -nostdlib -fno-builtin -Wall -Os -c -S
>> $(MAINBOARD)/$(CACHE_AS_RAM_AUTO_C) -o $@"
it's not really a fix because it depends on people not to drift again
over time. In the beginning, there was one way to set up this rule,
and then people changed it, and new files were created, and ... that's
why we are where we are now.
Since the config tool supports include files, why not exploit that
capability to fix this problem.
Longer term, we need a real set of Makefiles a la v3, and we need to
remove makerule from the Config.lb files. I suggest putting effort
there -- this is a flowery fix, and flowers are pretty, but this is
not fixing the real problem.
More information about the coreboot