[coreboot] typo in amdk8/raminit_f.c

Marc Jones marcj303 at gmail.com
Tue Apr 14 18:42:07 CEST 2009

On Mon, Apr 13, 2009 at 9:12 AM, Ronald Hoogenboom <ronald at zonnet.nl> wrote:
> Hi,
> There is a typo in amdk8/raminit_f.c regarding the preprocessor symbol
> QRANK_DIMM_SUPPORT in line 2208, which caused the protected code
> fragment never to be included for compilation.
> I guessed what the dimm_mask and sz.rank should have been (I'm not
> familiar with the functionality of this piece of code).
> Please review, anyone who is familiar (yhlu/mjones?).
> Signed-off-by: Ronald Hoogenboom <hoogenboom30 at zonnet.nl>

Did you find this on a qrank setup or just visual inspection? You fix
looks correct.

Acked-by: Marc Jones <marcj303 at gmail.com>



More information about the coreboot mailing list