[coreboot] [PATCH] Factor out ROM size calculation from Config.lb

Carl-Daniel Hailfinger c-d.hailfinger.devel.2006 at gmx.net
Mon Apr 20 09:53:10 CEST 2009

On 19.04.2009 18:54, Peter Stuge wrote:
> Stefan Reinauer wrote:
>>>> Index: LinuxBIOSv2-Configlb_refactor2/src/nofailovercalculation.lb
>>> src/config_includes/ please?
>> Please no new directory.
>> src/config is the right one for exactly that purpose.
> Yes, since there is a directory already that's much better!

Will do.

> But, and I forgot to ask this for this patch, please name it .cb though.

Can we please keep the naming of these files consistent? Right now, I
can do a
find -name "*.lb"
and get all config and include files. If I rename the include files
only, that will no longer work.

If we really want to rename all .lb to .cb, we should do that in one
separate commit. It will break every tree out there, so we'd better
think about this one. And given that Ron wants to convert most of the
stuff to real makefiles anyway, I am not sure we want to break
vendor/developer trees twice (once for .lb->.bc and once for real

> These improvements are really wonderful!


I'll hold off committing until I get an answer on the renaming stuff.



More information about the coreboot mailing list