[coreboot] [PATCH] flashrom - board enable - reconstruct table.

Peter Stuge peter at stuge.se
Mon Apr 20 15:52:04 CEST 2009

Carl-Daniel Hailfinger wrote:
> > We had this one before. It makes it unreadable for you. But not for 
> > everyone.
> Well, more flashrom developers on this list favour the multiline
> solution than those opposed to it. That means I'm part of the
> majority.

I'm not sure you are. I think you and I have been most active in that
file lately. Luc created it so if he still has interest I think his
opinion matters too.

> > What will you do when it reaches a hundred or so entries? Will
> > you be happy with a 1400line mess? 
> Is any table with 1400 lines a mess?

Not if it is 1400 lines of structured signal.

The long table format has a S/N ratio of 7% compared to the wide one,
which is really REALLY low.

> > How will people tell whether something similar has already been added?
> Like they do now.

I think the point is that with so much redundant information it is
tiring to work with. Not so bad for just adding new entries, but very
difficult to get an overview of, even when stretching out a terminal
over a full screen.

> Adding unique subsystem IDs to that struct is hard.

I agree. Interpreting the PCI and subsystem ids list for a system
(ie. finding which ids to use, or when there are no good ids) is more
difficult than actually adding the entry to the source code.


More information about the coreboot mailing list