[coreboot] Newbie source commit question

Peter Stuge peter at stuge.se
Sat Apr 25 15:00:50 CEST 2009

Hi Vincent,

Lim, Vincent wrote:
> I would like to add the family10h Rev C0-C2 support to coreboot and


> I just wanted to make sure I've got the procedure right.

As you may know by now, this is how it goes:

1. Work in local development tree
2. Generate patch file with svn diff
3. Send email to the list with log message, maybe some extra
   explanations, Signed-off-by: and the patch file.
4. Wait for Acked-by: or discussion.
5. If Acked-by: then commit with log message, which ends with
   Signed-off-by: and all Acked-by: received in 4.

In 3. some like to include the patch contents in the email body, some
attach the file, some do both. I like to use attachments because then
I don't have to worry about my mail program reformatting the patch in
case anyone wants to apply it to their development trees.

When using attachments, please check that the MIME type for the
attachment is set to text/plain (often automatic if the file name
ends with .patch) to allow easier reading for all list recipients.

Others can improve upon your patch, and then send a new patch with
their Signed-off-by: added to yours. In that case both developers who
signed off usually watch the discussion or the first can even ack the
new changes of the second. This is not very common, but has happened.

For trivial things such as reformatting, wording changes, and more,
it is fine to self-ack, ie. skip 2. 3. and 4. and instead commit
directly with Signed-off-by: and Acked-by: yourself.

Hope this helps!


More information about the coreboot mailing list