[coreboot] [PATCH]More consistent behaviour for printk_*

Patrick Georgi patrick at georgi-clan.de
Mon Apr 27 19:48:58 CEST 2009


the attached patch make printk_* behaviour more consistent. Without it, side 
effects in the arguments (eg. a pci config read, or variable increment) 
"vanish" with the message, and the behaviour changes.

printk_info("foo %d\n", i++);

Without this patch, this becomes (for suitable loglevels)
do {} while (0)

With this patch, this will be:
do_printk(EMERG, "", i++);

Some of these effects might be unwanted, but at least they are consistent now. 
For example, via c7 CAR failed for loglevel > 7 for various reasons (patch 
upcoming). While it fails all the time now (this patch is no "magic fix"), 
upcoming development is less likely to produce such "hidden surprises".

To reduce the memory footprint slightly, the formatted strings are discarded. 
A simpler patch would be to just kill the whole "#if #undef #define #endif"-
section, but then a lot of strings that never surface would be compiled in 
(and I doubt the compiler is clever enough to figure that out)

Signed-off-by: Patrick Georgi <patrick.georgi at coresystems.de>

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 20070427-1-more-consistent-printk-behaviour.patch
Type: text/x-patch
Size: 2086 bytes
Desc: not available
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20090427/2ec6ab8b/attachment.patch>

More information about the coreboot mailing list