[coreboot] [PATCH]More consistent behaviour for printk_*

Patrick Georgi patrick at georgi-clan.de
Mon Apr 27 20:41:25 CEST 2009


Am 27.04.2009 20:35, schrieb Carl-Daniel Hailfinger:
> Let me propose an alternative which does not have an empty printk call,
> yet keeps the side effects of all parameters.
>
> Signed-off-by: Carl-Daniel Hailfinger<c-d.hailfinger.devel.2006 at gmx.net>
>
> Index: LinuxBIOSv2-printk_level_side_effects/src/arch/i386/lib/console_printk.c
> ===================================================================
> --- LinuxBIOSv2-printk_level_side_effects/src/arch/i386/lib/console_printk.c	(Revision 4217)
> +++ LinuxBIOSv2-printk_level_side_effects/src/arch/i386/lib/console_printk.c	(Arbeitskopie)
> @@ -13,39 +13,39 @@
>
>   #if MAXIMUM_CONSOLE_LOGLEVEL<= BIOS_EMERG
>   #undef  printk_emerg
> -#define printk_emerg(fmt, arg...)   do {} while(0)
> +#define printk_emerg(fmt, arg...)   do { arg; } while(0)
...

The only gripe I have with this is that certain bugs stay uncovered (eg. 
the via c7 CAR thing). But granted, they're very rare (basically: when a 
printk_* call is in a place where function calls won't work).

Option #3 would be to just drop all the blocks. Someone with more taste 
than I should decide on this.


Patrick




More information about the coreboot mailing list