[coreboot] [PATCH] Kill duplicated code in Config.lb
rminnich at gmail.com
Fri Aug 28 14:51:16 CEST 2009
On Fri, Aug 28, 2009 at 5:45 AM, Carl-Daniel
Hailfinger<c-d.hailfinger.devel.2006 at gmx.net> wrote:
> r4534 introduced devicetree.cb in every mainboard directory, and 100% of
> that content was extracted from Config.lb in the same directory without
> eliminating the original contents.
> This patch fixes the dupliaction by using include statements.
> So far, I only tackled amd/dbm690t because it's the only target I can
> run a build+boot test for.
> Someone needs to fix the other 110 boards in the tree.
> Boot tested.
I would like to NAK this patch.
Our intent is that the Config.lb files DIE and be removed. Their
presence is only useful until such time as we make the cut to Kconfig
permanent. I would rather not take this patch, as it locks us into
backwards compatibiility for devicetree.cb -- if we improve sconfig in
some way,and change devicetree.cb, we have to worry every time we
change it that our change won't work for the old language. We thus
have to change the old parser every time we change the new one! This
is a lot of work for a tool we intend to remove.
This patch would lock us into a maintenance problem.
But thanks for looking.
More information about the coreboot