[coreboot] [v3][patch] Fix stdcall for asm to C call.

Carl-Daniel Hailfinger c-d.hailfinger.devel.2006 at gmx.net
Fri Feb 6 23:47:25 CET 2009

On 06.02.2009 23:34, Marc Jones wrote:
> Coreboot uses the compiler option -mregparm=3 which causes variables to be
> passed in registers. This is good for size and speed but not good when we
> call a C function from asm. Force stage1_phase1 to use stdcall and get
> variables off the stack.
> Note that I didn't change stage1_phase3 because it doesn't use any variables.
> Signed-off-by: Marc Jones <marcj303 at gmail.com>

Yes please! This is exactly the patch I sent months ago. There were
claims that it broke the Kontron board, but I doubt that. Back then,
nobody was willing to test, so the whole stage0/stage1 handoff patches
were reverted.
Oh, and the intel x86 handoff is wrong, but my fix for that was reverted
as well.

If we fix the buggy intel x86 stage0 code again, this is
Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net>



More information about the coreboot mailing list