[coreboot] patch: allow a .o (e.g. assembly) in building initram.

Peter Stuge peter at stuge.se
Fri Feb 20 00:48:21 CET 2009


ron minnich wrote:
> The initram build allows you to -fcombine the source. But if you put a 
> .S into the source file list, for reasons unknown, gcc only builds a .o 
> with the .S symbols/code in it; all the .c bits disappear. 
> 
> So, a few changes:
> 1. add a rule for secondary.o, we're going to need it. 
> 
> I like the fact that adding a .S file is inconvenient. Good. 
> Adding assembly should be hard. 
> 
> 2. Make two steps to initram .o building: first, the .c files, then any 
>     extra .o files as specified by the mainboard Makefile
> 
> I realize this is a bit ugly, if there is a better solution, I'll take it.
> 
> Signed-off-by: Ronald G. Minnich <rminnich at gmail.com>

Looks fine.

Acked-by: Peter Stuge <peter at stuge.se>




More information about the coreboot mailing list