[coreboot] ACPI patches for Tyan s2895, s2892, s2891

Carl-Daniel Hailfinger c-d.hailfinger.devel.2006 at gmx.net
Sat Feb 28 02:20:12 CET 2009

On 27.02.2009 23:23, Myles Watson wrote:
> These patches let Ubuntu 8.10 boot with ACPI support and no ACPI
> table-related warnings.  I haven't done SMM support yet, so that still
> complains and disables IRQ 9.
> Windows still doesn't like something, but I thought I'd contribute
> this code before I started using munged factory tables to see if I can
> get it to work that way.  Because resource allocation is totally
> different, the tables will need to be munged quite a bit :(
> _Tyan_common_tables.diff_
> This patch adds common elements for ck804-based boards.
> changes by file:
> src/arch/i386/boot/acpi.c:
> 	Be Paranoid and set srat_lapic table to zero before filling it.
> 	Enable SLIT filling if acpi_create_slit gets called.
> src/northbridge/amd/amdk8/northbridge.c:
> 	Add high tables code ala Stefan's code for the i945.
> src/northbridge/amd/amdk8/amdk8_util.asl:
> 	Put this file here instead of every board having a personal copy.

I didn't see the deletion of the per-board copies. Did subversion forget
to include them in the diff?

Besides that, moving the related fam10 file as well would be nice. Maybe
also a splitout of the K8 util ACPI code from the DBM690T and Pistachio
code, but that seems to be more work.

> src/northbridge/amd/amdk8/amdk8_acpi.c
> 	Silence warnings about implicit functions and format strings.
> src/arch/i386/include/arch/acpi.h:
> 	Add slit prototype and minor whitespace.
> Signed-off-by: Myles Watson <mylesgw at gmail.com>



More information about the coreboot mailing list