[coreboot] [PATCH] Convert print_* to printk_* in K8 RAM init

Carl-Daniel Hailfinger c-d.hailfinger.devel.2006 at gmx.net
Fri Jan 16 01:19:41 CET 2009

On 16.01.2009 00:58, Marc Jones wrote:
> On Thu, Jan 15, 2009 at 4:46 PM, Carl-Daniel Hailfinger
> <c-d.hailfinger.devel.2006 at gmx.net> wrote:
>> Since all K8 targets now have CONFIG_USE_PRINTK_IN_CAR enabled, using
>> print_* in K8 RAM init does not make sense anymore. Convert almost all
>> print_* to printk_*. This improves readability a lot and makes the code
>> shorter.
>> Reorder the SPD equality checks in the dual channel DIMM compatibility
>> checking code. This is to make sure that we know if any other mismatches
>> are present in the DIMM. The new order eases debugging with the old code.
>> Add a comment about false negatives in that code. This needs to be
>> implemented correctly, but that is hard to do in an efficient way.
>> Check if the DIMMS in a dual channel setup have any compatible CAS
>> latencies.
>> Add better comments to explain why wrong-at-first-glance SPD CL walking
>> code is actually correct.
>> Fix a few typos.
>> Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net>
> Acked-by: Marc Jones <marcj303 at gmail.com>

Thanks, r3865.



More information about the coreboot mailing list