[coreboot] r3901 - trunk/util/flashrom

svn at coreboot.org svn at coreboot.org
Mon Jan 26 01:39:58 CET 2009


Author: stuge
Date: 2009-01-26 01:39:57 +0100 (Mon, 26 Jan 2009)
New Revision: 3901

Modified:
   trunk/util/flashrom/flash.h
   trunk/util/flashrom/flashrom.c
Log:
flashrom: Change flashrom.c:map_flash_registers() from int to void.

The function exit()s on failure, and no callers check the return value.

Signed-off-by: Peter Stuge <peter at stuge.se>
Acked-by: Peter Stuge <peter at stuge.se>


Modified: trunk/util/flashrom/flash.h
===================================================================
--- trunk/util/flashrom/flash.h	2009-01-26 00:19:36 UTC (rev 3900)
+++ trunk/util/flashrom/flash.h	2009-01-26 00:39:57 UTC (rev 3901)
@@ -481,7 +481,7 @@
 
 /* flashrom.c */
 void mmap_errmsg();
-int map_flash_registers(struct flashchip *flash);
+void map_flash_registers(struct flashchip *flash);
 
 /* layout.c */
 int show_id(uint8_t *bios, int size, int force);

Modified: trunk/util/flashrom/flashrom.c
===================================================================
--- trunk/util/flashrom/flashrom.c	2009-01-26 00:19:36 UTC (rev 3900)
+++ trunk/util/flashrom/flashrom.c	2009-01-26 00:39:57 UTC (rev 3901)
@@ -95,7 +95,7 @@
 	}
 }
 
-int map_flash_registers(struct flashchip *flash)
+void map_flash_registers(struct flashchip *flash)
 {
 	volatile uint8_t *registers;
 	size_t size = flash->total_size * 1024;
@@ -109,8 +109,6 @@
 		exit(1);
 	}
 	flash->virtual_registers = registers;
-
-	return 0;
 }
 
 struct flashchip *probe_flash(struct flashchip *first_flash, int force)





More information about the coreboot mailing list