[coreboot] SB600 HDA can't find codec fix

Carl-Daniel Hailfinger c-d.hailfinger.devel.2006 at gmx.net
Tue Jan 27 03:29:03 CET 2009

Hi Dan,

thanks for the patch. I certainly appreciate fixes for SB600 HDA.

On 27.01.2009 02:46, Dan Lykowski wrote:
> These changes allow the SB600 HDA to detect the codec correctly. I haven't had time to test the sound output, but Linux now detects it correctly. I don't see why it wouldn't work. Feel free to give it a whirl and let me know if more work is needed.
> Signed-off-by: Dan Lykowski<lykowdk at gmail.com>

The patch is a bit difficult to read because it contains both whitespace
changes (and a total coding style change) and real changes.

I'm a bit sceptical about the INTA->INTG change, the reordering of stuff
inside hda_init() and a few other things as well (usage of dev_find_slot
may fail if that device is ever at another bus location).

Please explain your changes a bit more. Pointing to the official docs
will serve that purpose was well as long as you say what we should be
looking for (wrong init order etc.).

Oh, and please try to keep the existing coding style, especially the
whitespace conventions.



More information about the coreboot mailing list