[coreboot] [PATCH] Add Mitac 6513WU mainboard support

[Uwe Hermann]

On Sun, Jul 05, 2009 at 07:14:32PM -0400, Michael Gold wrote:
> This patch enables onboard VGA support for the Mitac 6513WU mainboard by
> defining CONFIG_VIDEO_MB.
> 
> Signed-off-by: Michael Gold <mgold at ncf.ca>

Thanks, r4402.


> I noticed that you moved the subtraction of 32 KB from CONFIG_ROM_SIZE
> (for the video BIOS) from the mainboard's Options.lb to the target's
> Config.lb, although the rom_address for this space in still listed in
> the mainboard's Config.lb.  Why was it changed?  The division between
> these files doesn't appear to be well documented, and is inconsistent in
> existing targets.

Yeah, true. We're not really consistent with most of the config option
stuff. In general, targets/.../Config.lb overrides src/.../Options.lb,
but which options are set in which file is inconsistent. IMHO most stuff
that a user might want to change (ROM_SIZE, VGA or not, etc) should be
in targets/.../Config.lb.

This might all change soonish when we use kconfig for building v2, so
it's probably not worth messing with it too much right now.


> > Changed this to the generic "../payload.elf" we try to use
> > everywhere now (but there may be more changes wrt to this
> > when we move to kconfig for v2).
> 
> That's fine, but it would be good to document the recommended practice
> since it's not done consistently in the existing code.

Yeah, also true. We could mass-patch all targets to use ../payload.elf
for consistency, but this will also be obsolete should we use kconfig
soon, so not sure if we want to do it right now.

I've set up a page for your board in the wiki:
http://www.coreboot.org/Mitac_6513WU
See http://www.coreboot.org/MSI_MS-6178 for an example page with status etc.

Feel free to update the status, either per email here and/or you request
a wiki account (email Stefan Reinauer <stepan at coresystems.de>).
We can also upload one or two photos of the board if you can create some
and are willing to put them into the public domain (or use CC or GPL).


Uwe.
-- 
http://www.hermann-uwe.de  | http://www.holsham-traders.de
http://www.crazy-hacks.org | http://www.unmaintained-free-software.org