[coreboot] msrtool CS5536 interrupt and DIVIL LBAR MSRs

Peter Stuge peter at stuge.se
Fri Jul 10 05:17:19 CEST 2009


Mart Raudsepp wrote:
> > > +		{ 0, 1, "IG8_STS_PRIM", "Primary Input 8", PRESENT_BIN, {
> > > +			{ MSR1(0), "No interrupt." },
> > > +			{ MSR1(1), "Interrupt status." },
> > > 
> > > Like Myles said, "Interrupt set" or maybe "Interrupt requested"
> > > for value '1'
> > 
> > I like set over requested, but status over set. Maybe signal
> > active or simply condition or signalled?
> 
> I was surprised to see this patch not included yet in some form.
> Do you need more review to an updated patch or just this poke? :)

Finally committed in r4414. Thanks to all!

I settled on "INTERRUPT" to make it stand out a little in a long
decode output.


//Peter




More information about the coreboot mailing list