[coreboot] [patch] [AMD Fam10] Fix confused RB-C2 and DA-C2

[Ward Vandewege]

Hi Zheng,

On Thu, Jul 16, 2009 at 03:40:49PM +0800, Bao, Zheng wrote:
> This patch is about the DA-C2 and RB-C2. Chip with install processor
> Revision ID of 0x100F62 is DA-C2, instead of RB-C2 which was incorrectly
> defined in raminit_amdmct.c. RB-C2's ID is 0x100F42. The Erratas applied
> to them are almost the same.

Aha. That would perhaps explain why my box with 

  Quad-Core AMD Opteron(tm) Processor 2372 HE

with revision id 0x100f42 really does not like ucode revision 92 (it resets
itself constantly).

> Issues:
> 1. I really dont know what their nicknames are (Shanghai C2 or
> something).

Don't know about that.

> 2. About the mc_patch_01000086.h, I dont know if it is allowed to be
> released.
>    If you really need it, please contact AMD Inc to see if it is public.

Well, I have my box booting without any ucode update. It would be nice to
have mc_patch_01000086.h public if that's the revision for my cpus. Who do I
ask?

> 3. I haven't made coreboot go thoroughly on this RB-C2. This patch is
> just half tested.

I now have a working tree for Supermicro h8dmr with RB-C2 but it needs a bit
more tweaking and cleaning up. I hope to get that ready soon so I can submit
the patch to the list.

>    I am not confident it is 100% correct.

I'll test tonight or tomorrow and let you know how it goes.

Thanks!
Ward.

-- 
Ward Vandewege <ward at gnu.org>