[coreboot] [v2] r4451 - trunk/coreboot-v2/src/config

svn at coreboot.org svn at coreboot.org
Tue Jul 21 23:31:36 CEST 2009

Author: stepan
Date: 2009-07-21 23:31:36 +0200 (Tue, 21 Jul 2009)
New Revision: 4451

Add more warnings to CFLAGS, and also add some to HOSTCFLAGS
include ldoptions from ldscript.ld instead appending it.

Not everyone was happy about the -Wmissing-prototypes in CFLAGS. 
I put it in there now anyways, so everyone can get an overview which parts of
their code could use some cleanup. If it gets too ugly, we can still remove
that flag again.

Signed-off-by: Stefan Reinauer <stepan at coresystems.de>
Acked-by: Peter Stuge <peter at stuge.se>
Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net>

Modified: trunk/coreboot-v2/src/config/Config.lb
--- trunk/coreboot-v2/src/config/Config.lb	2009-07-21 21:25:45 UTC (rev 4450)
+++ trunk/coreboot-v2/src/config/Config.lb	2009-07-21 21:31:36 UTC (rev 4451)
@@ -10,17 +10,17 @@
 makedefine GCC_INC_DIR := $(shell LC_ALL=C $(GCC) -print-search-dirs | sed -ne "s/install: \(.*\)/\1include/gp")
 makedefine CPPFLAGS := -I$(TOP)/src/include -I$(TOP)/src/arch/$(CONFIG_ARCH)/include -I$(GCC_INC_DIR) $(CPUFLAGS)
-makedefine CFLAGS := $(CONFIG_CPU_OPT) $(DISTRO_CFLAGS) $(CPPFLAGS) -Os -nostdinc -nostdlib -Wall -Wundef -Wstrict-prototypes -Wno-trigraphs -Werror-implicit-function-declaration -Wstrict-aliasing -Wshadow -fno-common -ffreestanding -fno-builtin -fomit-frame-pointer
+makedefine CFLAGS := $(CONFIG_CPU_OPT) $(DISTRO_CFLAGS) $(CPPFLAGS) -Os -nostdinc -nostdlib -Wall -Wundef -Wstrict-prototypes -Wmissing-prototypes -Wwrite-strings -Wredundant-decls -Wno-trigraphs -Werror-implicit-function-declaration -Wstrict-aliasing -Wshadow -fno-common -ffreestanding -fno-builtin -fomit-frame-pointer
 makedefine DEBUG_CFLAGS := -g -dA -fverbose-asm
-makedefine HOSTCFLAGS:= -Os -Wall
+makedefine HOSTCFLAGS:= -Os -Wall -Wstrict-prototypes -Wmissing-prototypes -Wredundant-decls -Wno-trigraphs -Werror-implicit-function-declaration -Wstrict-aliasing -Wshadow
 makerule ldscript.ld   
 	depends	"ldoptions $(LDSUBSCRIPTS-1)" 
-	action	"echo '/*ldoptions*/' > $@; cat ldoptions >> $@ ; for file in $(LDSUBSCRIPTS-1) ; do echo /\* $$file \*/ >> $@; cat $$file >> $@ ; done"
+	action  "echo 'INCLUDE ldoptions' > $@; for file in $(LDSUBSCRIPTS-1) ; do echo /\* $$file \*/ >> $@; cat $$file >> $@ ; done"
 #makerule cpuflags   

More information about the coreboot mailing list