[coreboot] [PATCH] K8: Improve RAM init debug messages
Carl-Daniel Hailfinger
c-d.hailfinger.devel.2006 at gmx.net
Fri Jun 5 15:34:59 CEST 2009
On 05.06.2009 13:44, Stefan Reinauer wrote:
> On 05.06.2009 12:43 Uhr, Carl-Daniel Hailfinger wrote:
>
>> /* Report the amount of memory. */
>> - printk_spew("RAM: 0x%08x kB\n", tom_k);
>> + printk_debug("RAM end at 0x%08x kB, hole starts at 0x%08x kB\n",
>> + tom_k, hole_startk);
>>
>> /* Now set top of memory */
>> msr_t msr;
>> if (tom_k > (4*1024*1024)) {
>> + printk_raminit("Handling memory mapped above 4 GB\n");
>> + printk_raminit("Upper RAM end at 0x%08x kB\n", tom_k);
>>
>>
>
> I'm not sure it gets any easier to understand or less cryptic by calling
> the amount of RAM end of RAM and printing it twice?
>
Actually, it's the end of RAM. On my 4 GB machine, tom_k is 0x00500000
which is 5*1024*1024. The hole starts at 3 GB in that configuration.
However, printing it twice serves no purpose. I'll fix and resend.
Regards,
Carl-Daniel
--
http://www.hailfinger.org/
More information about the coreboot
mailing list