[coreboot] [flashrom] [PATCH] external serial flasher protocol support
Urja Rannikko
urjaman at gmail.com
Wed Jun 10 20:00:06 CEST 2009
On Wed, Jun 10, 2009 at 13:34, Frieder
Ferlemann<frieder.ferlemann at web.de> wrote:
> Hi,
>
> from serial-flash-protocol.txt
>
> #define S_ACK 0x10
> #define S_NAK 0xBA
>
> Could these be 0x06 and 0x15 respectively so it's more inline with
> http://en.wikipedia.org/wiki/C0_and_C1_control_codes ?
>
Why not but why to change.
Is there some technical reason to follow the ASCII control codes in
this binary protocol?
Maybe i should have called them S_OK and S_BAD, or S_YES and S_NO, or
S_SMILE and S_FROWN :P
They are just two values used to represent success/failure in command
execution - i dont really care much of their numerical values.
--
urjaman
More information about the coreboot
mailing list