[coreboot] Error with flashrom make file on FC10

[Joseph Smith]

On Tue, 16 Jun 2009 01:37:40 +0200, Carl-Daniel Hailfinger
<c-d.hailfinger.devel.2006 at gmx.net> wrote:
> On 13.06.2009 21:04, Joseph Smith wrote:
>> [root at localhost flashrom]# make
>> make: Warning: File `Makefile' has modification time 1.3e+09 s in the
>> future
>>
>> Checking for pciutils and zlib... not found.
>>
>> Please install pciutils-devel and zlib-devel.
>> See README for more information.
>>
>> make: *** [pciutils] Error 1
>>
> 
> Turns out gcc was not installed.
> 
> No idea whether we really should check for a working gcc. Anyway, here's
> a patch.
> 
> Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net>
> 
> Index: flashrom-makefile_check_gcc/Makefile
> ===================================================================
> --- flashrom-makefile_check_gcc/Makefile	(Revision 595)
> +++ flashrom-makefile_check_gcc/Makefile	(Arbeitskopie)
> @@ -80,7 +80,16 @@
>  strip: $(PROGRAM)
>  	$(STRIP) $(STRIP_ARGS) $(PROGRAM)
> 
> -pciutils:
> +compiler:
> +	@echo; printf "Checking for a C compiler... "
> +	@$(shell ( echo "int main(int argc, char **argv)"; \
> +		   echo "{ return 0; }"; ) > .test.c )
> +	@$(CC) $(CFLAGS) $(LDFLAGS) .test.c -o .test >/dev/null &&	\
> +		echo "found." || ( echo "not found."; \
> +		rm -f .test.c .test; exit 1)
> +	@rm -f .test.c .test
> +
> +pciutils: compiler
>  	@echo; printf "Checking for pciutils and zlib... "
>  	@$(shell ( echo "#include <pci/pci.h>";		   \
>  		   echo "struct pci_access *pacc;";	   \
> @@ -110,6 +119,6 @@
>  	@rm -rf $(EXPORTDIR)/flashrom-$(VERSION)
>  	@echo Created $(EXPORTDIR)/flashrom-$(VERSION).tar.gz
> 
> -.PHONY: all clean distclean dep pciutils export tarball
> +.PHONY: all clean distclean dep compiler pciutils export tarball
> 
>  -include .dependencies
> 

Thanks for the idiot proof patch for people like me that do a fresh Linux
install and just assume gcc comes installed :-)

Acked-by: Joseph Smith <joe at settoplinux.org>

-- 
Thanks,
Joseph Smith
Set-Top-Linux
www.settoplinux.org