[coreboot] [patch][v2]:fam10 microcode

Maximilian Thuermer Maximilian.Thuermer at stud.uni-karlsruhe.de
Tue Jun 16 11:40:40 CEST 2009

Marc Jones schrieb:
> Hi Maximilian,
> Very good catch. I am suprised we didn't see this sooner.
> The bug is that the code was always updating the passed value to the
> next link offset even when it was on the requested link (cap_count). I
> think that your patch has a slight problem in that it skips the CapID
> and CapType check on the first link, link_no == 0.
> Attached is a slightly different fix (untested). I think that this
> function could be rewritten to be more clear but this is what you get
> when tying to keep code similarity when going from asm to C.....
> Please review and test.
> Signed-off-by: Marc Jones <marcj303 at gmail.com>
> Thanks,
> Marc

Hi Marc,

this patch looks like it should do the trick.
Can't test it until next Monday though, but I will let you know how it 
turned out...



More information about the coreboot mailing list