[coreboot] [PATCH] Flashrom: board enable for Mitac 6513WU

[Luc Verhaegen]

On Fri, Jun 19, 2009 at 07:38:43AM -0400, Michael Gold wrote:
> On Fri, Jun 19, 2009 at 13:05:49 +0200, Luc Verhaegen wrote:
> > On Fri, Jun 19, 2009 at 02:13:35AM -0400, Michael Gold wrote:
> > > I've also attached the lspci output.
> > > 
> > > Why do you think coreboot support is unlikely?  Is 82810E support a
> > > problem?
> > > 
> > > -- Michael
> > 
> > It is a laptop, so yes, quite unlikely. On the other hand, if coreboot 
> > support gets added, you probably won't do this board specific rom access 
> > disable :)
> 
> It's a desktop board with these chips:
>   Intel 82810e GMCHe
>   Intel 82801AA ICH
>   SMSC LPC47U332 super I/O
> 
> The manual is at http://www.motherboards.org/files/manuals/78/6513WU.pdf
> 
> The 82810e isn't listed as supported on the wiki, but the 82810 is, and
> their datasheets appear largely identical based on a quick look.  I was
> hoping to get coreboot running on it.

Ah, i only know mitac as a laptop odm.

In that case, you do not want the coreboot ids because you will 
hopefully not set the board specific rom disable in your coreboot code.

> > > +	{0x8086, 0x2411, 0x8086, 0x2411,  0x8086, 0x7125, 0x0e11, 0xb165, NULL,         NULL,          "Mitac",       "6513WU",             board_mitac_6513wu},
> > 
> > From your pciids i would use:
> > 	{0x8086, 0x7125, 0x0e11, 0xb165,  0x125d, 0x1988, 0x0e11, 0xb19d
> > 
> > instead, as the first oen uses just a copy of the main ids. 0x0e11 is 
> > compaq.
> 
> I avoided the 0x125d ID because that's the onboard audio, and there's a
> jumper to disable it.  I've now confirmed that the device disappears
> from lspci when that jumper is moved, so I don't think it's an
> appropriate device for autodetection.  The other devices on bus 1 (09
> and 0a) are also unusable since those are PCI cards.

Ok, makes sense.

> 
> > > 00:01.0 0300: 8086:7125 (rev 03) (prog-if 00 [VGA controller])
> > > 	Subsystem: 0e11:b165
> > 
> > > 01:05.0 0401: 125d:1988 (rev 10)
> > > 	Subsystem: 0e11:b19d
> > 
> > Can you verify this?
> 
> I'm not sure what you mean, but those IDs do appear in the config space
> for the devices when lspci's -x flag is used.
> 
> -- Michael

Ok, patch going in.

Luc Verhaegen.