[coreboot] [PATCH] flashrom: SB600 SPI: Kill unused variable

Carl-Daniel Hailfinger c-d.hailfinger.devel.2006 at gmx.net
Mon Jun 22 16:31:44 CEST 2009


SB600 SPI: Kill unused variable.

Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net>

Index: flashrom-sb600spi_unneeded_struct/sb600spi.c
===================================================================
--- flashrom-sb600spi_unneeded_struct/sb600spi.c	(Revision 622)
+++ flashrom-sb600spi_unneeded_struct/sb600spi.c	(Arbeitskopie)
@@ -25,6 +25,7 @@
 #include "flash.h"
 #include "spi.h"
 
+/* This struct is unused, but helps visualize the SB600 SPI BAR layout. */
 struct sb600_spi_controller {
 	unsigned int spi_cntrl0;	/* 00h */
 	unsigned int restrictedcmd1;	/* 04h */
@@ -36,7 +37,6 @@
 	unsigned int spi_fakeid;	/* 1Ch */
 };
 
-struct sb600_spi_controller *spi_bar = NULL;
 uint8_t *sb600_spibar;
 
 int sb600_spi_read(struct flashchip *flash, uint8_t *buf, int start, int len)
@@ -111,8 +111,6 @@
 
 	writecnt--;
 
-	spi_bar = (struct sb600_spi_controller *) sb600_spibar;
-
 	printf_debug("%s, cmd=%x, writecnt=%x, readcnt=%x\n",
 		     __func__, cmd, writecnt, readcnt);
 


-- 
http://www.hailfinger.org/

-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: flashrom_sb600spi_unneeded_struct.diff
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20090622/cc22c194/attachment.ksh>


More information about the coreboot mailing list