[coreboot] [PATCH] flashrom: SB600 SPI: Kill unused variable

Bao, Zheng Zheng.Bao at amd.com
Thu Jun 25 04:36:26 CEST 2009

Originally I defined the struct and access the controller by the member
of the struct. But the code couldn't work at first. Then I changed every
"a->b" to "a[XX]". Obviously it doesn't make any sense. Now the code has
been working so far, but I haven't got passion to change them back.
Maybe later I will do it.


-----Original Message-----
From: coreboot-bounces at coreboot.org
[mailto:coreboot-bounces at coreboot.org] On Behalf Of Carl-Daniel
Sent: Tuesday, June 23, 2009 8:49 AM
To: Luc Verhaegen
Cc: Coreboot
Subject: Re: [coreboot] [PATCH] flashrom: SB600 SPI: Kill unused

On 23.06.2009 00:09, Luc Verhaegen wrote:
> On Mon, Jun 22, 2009 at 04:31:44PM +0200, Carl-Daniel Hailfinger
>> SB600 SPI: Kill unused variable.
>> Signed-off-by: Carl-Daniel Hailfinger
<c-d.hailfinger.devel.2006 at gmx.net>
> If this builds, then what can be wrong with this :)
> I guess you are keeping this struct because publically available 
> documentation is perhaps not as clear as it should be?

Well, the documentation is pretty readable, but the struct is a handy
compressed reference and useful if you want to avoid reading dozens of
datasheet pages.

> Why not comment 
> it completely so that no-one else will complain about it in future?


> Please also make reset_internal_fifo_pointer and execute_command
> so thatthese symbols, when unused, will turn up in the build as well.


> Apart from that, of course:
> Acked-by: Luc Verhaegen <libv at skynet.be>

Thanks, committed in r623.



coreboot mailing list: coreboot at coreboot.org

More information about the coreboot mailing list