[coreboot] CBFS Corrupt ROM error fix

Myles Watson mylesgw at gmail.com
Thu Jun 25 17:48:54 CEST 2009

rom 0x6063c0 offset 0 ROM_PTR 0x7ffa30621000 fssize 458752
rom 0x6063c0 offset 458720 ROM_PTR 0x7ffa30690fe0 fssize 458752
Corrupt rom -- found no header at 458720

The problem is that the check to see if we're at the end is never reached.
I didn't look into it enough to know why fssize is 32 bytes larger than the
offset.  There may be another bug here.  Maybe something with the CBFS
header not being included or excluded from the calculation?

Anyway, this patch fixes it for all cases size > 32.  I'll review better
fixes :)  I also changed the error message so that it doesn't look like the
ROM is full just because it can't find room for a file.

Signed-off-by: Myles Watson <mylesgw at gmail.com>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20090625/e664375a/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: corrupt.diff
Type: text/x-patch
Size: 601 bytes
Desc: not available
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20090625/e664375a/attachment.diff>

More information about the coreboot mailing list