[coreboot] [patch][msrtool] Add K8 MSRs

Stefan Reinauer stepan at coresystems.de
Fri Mar 6 00:09:09 CET 2009

Marc Jones wrote:
>>> -const uint32_t msraddrbyname(const char *name) {
>>> +uint32_t msraddrbyname(const char *name) {
>> Any reason for the const removal? The changelog doesn't say anything
>> about it
> That was to get it to compile with -Werror which is on by default. It
> didn't look like that really needed to be a const.
Does the const make sense at all? It seems odd to define the variable
integer return value of a function const. What's that supposed to be
good for?


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 249 bytes
Desc: OpenPGP digital signature
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20090306/8c866cab/attachment.sig>

More information about the coreboot mailing list