[coreboot] [PATCH] v2 i945 updates

Peter Stuge peter at stuge.se
Wed Mar 11 17:15:17 CET 2009


Stefan Reinauer wrote:
> i945 northbridge update
> - lots of PCIe updates
> - various bug fixes to early init
> - some fixes for typos and warnings
> - initial support for PCIe x16
> - some minor fixes to memory init code
> - some subsystem vendor id patches, to be consistent with ICH7
> Signed-off-by: Stefan Reinauer <stepan at coresystems.de>

Here is a plea:

Please PLEEASE do not include whitespace fixes in other patches!!

That requires THREE or FOUR times the effort for every review - and
the result is that less people will bother to look at the code!

It is a waste of reviewer time.

How to easily check it? My suggestion is to always read every svn
diff output before sending.

Acked-by: Peter Stuge <peter at stuge.se>

More information about the coreboot mailing list