[coreboot] [PATCH]es for v2: build system fixes and changes, and scan-build support
peter at stuge.se
Wed Mar 11 17:27:03 CET 2009
Patrick Georgi wrote:
> Attached patch is more suitable for inclusion into the v3 tree. It adds
> a "support clang" option to kconfig, and only mangles the variables in
> question when that option is active.
I don't like the particular implementation too much.
> +++ Kconfig (working copy)
> +config SCAN_BUILD
> +++ util/xcompile/xcompile (working copy)
> +if [ "$1" = "y" ]; then
> + scanbuild=true
> +++ Makefile (working copy)
> -CC := gcc
> +CC ?= gcc
> -HOSTCC := gcc
> +HOSTCC := $(CC)
> +include $(shell $(src)/util/xcompile/xcompile $(CONFIG_SCAN_BUILD) > $(src)/.xcompile || \
Couldn't this connection between Kconfig and xcompile work better?
I don't like that it's circular: Makefile is needed to create
xcompile which is needed to use Makefile..
I didn't express myself very clearly - do you still get my point?
More information about the coreboot