[coreboot] [PATCH] Fix RS690 MMCONFIG access
stepan at coresystems.de
Wed Mar 18 13:57:34 CET 2009
On 18.03.2009 12:43 Uhr, Carl-Daniel Hailfinger wrote:
> On 18.03.2009 12:29, Peter Stuge wrote:
>> Carl-Daniel Hailfinger wrote:
>>> 2. If the MMCONFIG area should be relocatable (possible on RS690),
>>> make sure it gets special handling (disable directly before
>>> relocation, reenable directly after relocation).
>> I like this the best. Well done finding+fixing the bug!
>> If you don't feel like taking this on at the moment maybe it's a good
>> candidate for a ticket in trac,
> I'm seriously time-contrained (max. coreboot time is a few minutes per
> week) until April 7th due to university exams. Could you please open a
> ticket or look otherwise into this?
>> and the ugly workaround can be
>> Acked-by: Peter Stuge <peter at stuge.se>
> The workaround unfortunately pollutes every single x86 board in the tree
> with RS690 specific code, so I'm hesitant to apply it. And I don't fully
> understand the v2 device model, so I have no idea where to place the
> correct fix.
I think it might belong in chip->dev_init of the rs690.
coresystems GmbH • Brahmsstr. 16 • D-79104 Freiburg i. Br.
Tel.: +49 761 7668825 • Fax: +49 761 7664613
Email: info at coresystems.de • http://www.coresystems.de/
Registergericht: Amtsgericht Freiburg • HRB 7656
Geschäftsführer: Stefan Reinauer • Ust-IdNr.: DE245674866
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the coreboot