[coreboot] [PATCH]es 7 assorted fixes

Carl-Daniel Hailfinger c-d.hailfinger.devel.2006 at gmx.net
Thu Mar 19 12:34:33 CET 2009


On 18.03.2009 18:32, Mart Raudsepp wrote:
> Ühel kenal päeval, N, 2008-10-23 kell 03:41, kirjutas Carl-Daniel
> Hailfinger:
>   
>> On 23.10.2008 01:38, ron minnich wrote:
>>     
>>> Jens, I am very happy to see these contributions from Lippert. I hope
>>> you or someone from this list can look at bringing them forward to v3
>>> as well.
>>>       
>> This is the GeodeLX RAM speed calculation patch for v3.
>>
>> Changed RAM speed calculation to fix RAM modules getting rejected only
>> due to integer rounding errors. Previously, the formula was:
>> 	speed = 2 * (10000/spd_value)
>> For spd_value=60 this means speed = 2 * 166 = 332, which is less than
>> 333 and coreboot died saying RAM was incompatible. The new formula is:
>> 	speed = 20000 / spd_value
>> For spd_value=60, speed=333, which is fine.
>>
>> Signed-off-by: Jens Rottmann <JRottmann at LiPPERTEmbedded.de>
>> Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net>
>>     
>
> Tested on ThinCan DBE63 to fix the issue of 333 > 332 comparison for RAM
> modules I had problems with before due to bailing out in the
> overclocking check.
>
> Acked-by: Mart Raudsepp <mart.raudsepp at artecdesign.ee>
>   

Thanks, committed in r1157.

Regards,
Carl-Daniel

-- 
http://www.hailfinger.org/





More information about the coreboot mailing list