[coreboot] r1157 - coreboot-v3/northbridge/amd/geodelx
peter at stuge.se
Thu Mar 19 14:18:22 CET 2009
Peter Stuge wrote:
> svn at coreboot.org wrote:
> > - speed = 2 * ((10000 / (((spd_byte0 >> 4) * 10) + (spd_byte0 & 0x0F))));
> > + speed = 20000 / (((spd_byte0 >> 4) * 10) + (spd_byte0 & 0x0F));
> Anyone else thinks this calls for a macro? Maybe even a generic SPD
As it turns out, some restructuring here would be nice.
Making use of goto in a select few places makes it very obvious that
this function isn't completely consistent. Is that a potential
problem for RAM init or is it just an academic discovery? I don't
have enough experience from SPD data..
I would think that every occurence of goto dimm1 in my patch should
be preceded by casmap0=0. Do you agree?
I suggest that this patch does not change how the code works.
More information about the coreboot