[coreboot] [PATCH] Remove warnings for s2892
Peter Stuge
peter at stuge.se
Fri May 1 01:46:57 CEST 2009
Myles Watson wrote:
> +++ cbv2/src/pc80/keyboard.c 2009-04-30 15:47:16.000000000 -0600
> @@ -112,11 +112,11 @@
> outb(0x60, 0x64);
> if (!kbc_input_buffer_empty()) return;
> outb(0x20, 0x60); /* send cmd: enable keyboard and IRQ 1 */
> - u8 resend = 10;
> + u8 broken_resend = 10;
> if ((inb(0x64) & 0x01)) {
> regval = inb(0x60);
> }
> - --resend;
> + --broken_resend;
> } while (regval == 0xFE && resend > 0);
This does not look right to me. I think the good fix is to not rename
things but only remove the u8 (re)declaration on line 115. Very good
find!
//Peter
More information about the coreboot
mailing list